Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): add submitter type to SubmitFunction input argument #9484

Merged
merged 2 commits into from Mar 22, 2023

Conversation

igneosaur
Copy link
Contributor

@igneosaur igneosaur commented Mar 22, 2023

Fixes #9483

This PR adds an additional submitter typing to the duplicate of SubmitFunction in kit/types/index.d.ts. The main feature was added here.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2023

🦋 Changeset detected

Latest commit: eec41fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@igneosaur igneosaur changed the title fix(kit): add submitter type to SubmitFunction input argument fix(kit): add submitter type to SubmitFunction input argument Mar 22, 2023
@dummdidumm
Copy link
Member

Thank you! Could you add a changeset? Then we can merge this.

@dummdidumm dummdidumm merged commit f1beb92 into sveltejs:master Mar 22, 2023
@github-actions github-actions bot mentioned this pull request Mar 22, 2023
@igneosaur igneosaur deleted the fix-create-svelte-test branch March 22, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

submitter is not typed in packages/kit/types/index.d.ts SubmitFunction arguments
2 participants