New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: balance parentheses in error about wrong content type for action #9513
Conversation
🦋 Changeset detectedLatest commit: b7ba460 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -214,7 +214,7 @@ async function call_action(event, actions) { | |||
|
|||
if (!is_form_content_type(event.request)) { | |||
throw new Error( | |||
`Actions expect form-encoded data (received ${event.request.headers.get('content-type')}` | |||
`Actions expect form-encoded data (received ${event.request.headers.get('content-type')})` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another alternative would be to remove the parentheses. I'll leave this as a suggestion to see if the other maintainers have any preference
`Actions expect form-encoded data (received ${event.request.headers.get('content-type')})` | |
`Actions expect form-encoded data, but received ${event.request.headers.get('content-type')}` |
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
When you send the wrong content type to an action, SvelteKit throws a helpful error, but it's missing the parentheses at the end:
This PR adds it. That's all! Thanks!
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.