Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: balance parentheses in error about wrong content type for action #9513

Merged
merged 3 commits into from Mar 30, 2023
Merged

fix: balance parentheses in error about wrong content type for action #9513

merged 3 commits into from Mar 30, 2023

Conversation

danieldiekmeier
Copy link
Contributor

When you send the wrong content type to an action, SvelteKit throws a helpful error, but it's missing the parentheses at the end:

Actions expect form-encoded data (received application/json;
                                                            ^ Whoops

This PR adds it. That's all! Thanks!

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2023

🦋 Changeset detected

Latest commit: b7ba460

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danieldiekmeier danieldiekmeier changed the title Balance parantheses in error about wrong content type for action fix: Balance parantheses in error about wrong content type for action Mar 25, 2023
@@ -214,7 +214,7 @@ async function call_action(event, actions) {

if (!is_form_content_type(event.request)) {
throw new Error(
`Actions expect form-encoded data (received ${event.request.headers.get('content-type')}`
`Actions expect form-encoded data (received ${event.request.headers.get('content-type')})`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another alternative would be to remove the parentheses. I'll leave this as a suggestion to see if the other maintainers have any preference

Suggested change
`Actions expect form-encoded data (received ${event.request.headers.get('content-type')})`
`Actions expect form-encoded data, but received ${event.request.headers.get('content-type')}`

@danieldiekmeier danieldiekmeier changed the title fix: Balance parantheses in error about wrong content type for action fix: Balance parentheses in error about wrong content type for action Mar 26, 2023
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@benmccann benmccann changed the title fix: Balance parentheses in error about wrong content type for action fix: balance parentheses in error about wrong content type for action Mar 27, 2023
@Rich-Harris Rich-Harris merged commit 80e95e2 into sveltejs:master Mar 30, 2023
10 of 11 checks passed
@github-actions github-actions bot mentioned this pull request Mar 30, 2023
@danieldiekmeier danieldiekmeier deleted the patch-2 branch March 30, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants