New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: route-level entry generators #9571
Merged
Merged
Changes from 21 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
74016df
feat: It basically works lol
tcc-sejohnson 05c7d4e
feat: Typings for page routes
tcc-sejohnson 1b2e1e0
Revert "feat: Typings for page routes"
tcc-sejohnson a3a7189
feat: Types!
tcc-sejohnson d0389ca
fix: naming
tcc-sejohnson fa48df5
fix: naming
tcc-sejohnson 7412ea5
fix: More future-proof types
tcc-sejohnson e21340c
feat: Throw by default if entry generator matches a different route ID
tcc-sejohnson 7f88557
feat: Better validation, separage +page and +layout
tcc-sejohnson d6655f4
feat: Tests for mismatch errors
tcc-sejohnson d369212
feat: Tests for route_from_entry
tcc-sejohnson a07bf20
fix: naming
tcc-sejohnson df1acb9
feat: typedoc
tcc-sejohnson 7758ea9
fix: blargh
tcc-sejohnson b0e0a54
feat: One-line docs -- where should we put an example?
tcc-sejohnson 41d7895
fix: nittiest of nits
tcc-sejohnson 0ae2351
feat: Changeset
tcc-sejohnson 57632cd
Update packages/kit/src/utils/routing.js
tcc-sejohnson b1d8667
merge master
19ef1b8
rename route_from_entry -> resolve_entry
7ae49fc
fix lockfile
067b309
update lockfile
fcb442a
add docs
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@sveltejs/kit': minor | ||
--- | ||
|
||
feat: route-level entry generators via `export const entries` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's too little to add to the docs for this feature. We need some place to explain it properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree -- I called this out in the PR description. I wasn't sure where we'd want to put this, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably in page options at the very least, and maybe also reference it in some of the prerender-related docs.