Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add HEAD handler #9753

Merged
merged 12 commits into from Jul 4, 2023
Merged

feat: add HEAD handler #9753

merged 12 commits into from Jul 4, 2023

Conversation

eltigerchino
Copy link
Member

closes #9468

Allows exporting the HEAD handler. Not sure if language-tools needs to be updated to remove the error message for this as well.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2023

🦋 Changeset detected

Latest commit: 93fb961

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

@s3812497 it looks like this PR will need a rebase

@eltigerchino
Copy link
Member Author

Thanks for the reminder @benmccann . I've just learnt what a rebase is. I did a merge before that (hence the force push trying to undo that). Will use rebase from now on.

@benmccann
Copy link
Member

Oh, I just use the term rebase out of habit. But really I think folks prefer if you do a merge because if they have the code checked out it's easier to pull a merge

@dummdidumm
Copy link
Member

@s3812497 this has a merge conflict - can you look at it today? Else I'll look into it later.

@eltigerchino
Copy link
Member Author

@s3812497 this has a merge conflict - can you look at it today? Else I'll look into it later.

Sure thing! I'll have a look at it now.

@dummdidumm dummdidumm merged commit c1ad5b2 into master Jul 4, 2023
14 checks passed
@dummdidumm dummdidumm deleted the feat-head-endpoint branch July 4, 2023 13:50
@benmccann
Copy link
Member

I wonder if we'd want some sort of fallback implementation which executes GET and returns just the headers or if that defeats the purpose? I've never used HEAD before

@github-actions github-actions bot mentioned this pull request Jul 4, 2023
@dummdidumm
Copy link
Member

That fallback already exists today, and will still apply if you don't define the HEAD yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HEAD reported as an invalid request handler
3 participants