Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file not found in manifest during build #9846

Merged
merged 2 commits into from May 5, 2023
Merged

fix: file not found in manifest during build #9846

merged 2 commits into from May 5, 2023

Conversation

gtm-nayan
Copy link
Contributor

@gtm-nayan gtm-nayan commented May 4, 2023

fixes #9843

This ensures there is a key for these files in the manifest. Surely there has got to be a better way than this but just leaving it here in case the problems are more widespread and needs a fix overnight. Slightly less efficient than not having these entry points but still beats what we had before.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented May 4, 2023

🦋 Changeset detected

Latest commit: aae2b20

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

You have this in draft mode - does this mean you want to look into a better solution because you know there likely is one, or can we merge the current solution?

@gtm-nayan
Copy link
Contributor Author

Probably should go ahead with this. Couldn't find any practical way to map the nodes to their chunks. It gets hairier cause parts of a module might end up in different chunks so putting them as entry points seems like the only way for now to guarantee they're in the manifest.

Perhaps @bluwy or @dominikg might know of something. In some rudimentary testing, I found that turning off preserveEntrySignatures gets it down to the same number as without the entrypoints so that could be worth looking into, but later.

@gtm-nayan gtm-nayan marked this pull request as ready for review May 5, 2023 11:05
@dummdidumm dummdidumm merged commit 63180c9 into master May 5, 2023
13 checks passed
@dummdidumm dummdidumm deleted the fix-9811 branch May 5, 2023 11:12
@github-actions github-actions bot mentioned this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build breaks since 1.15.11 when importing a file asynchronously in onMount (and using a monorepo?)
2 participants