Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svelte-check should fail when no files are checked #1952

Closed
DetachHead opened this issue Mar 22, 2023 · 2 comments
Closed

svelte-check should fail when no files are checked #1952

DetachHead opened this issue Mar 22, 2023 · 2 comments
Labels
contributions welcome pull requests for this issue welcome feature request New feature or request Fixed Fixed in master branch. Pending production release. good first issue Good for newcomers

Comments

@DetachHead
Copy link
Contributor

Description

tsc fails if no files were checked:

> tsc
error TS18003: No inputs were found in config file 'C:/project/tsconfig.json'. Specified 'include' paths were '[]' and 'exclude' paths were '[]'.


Found 1 error.

however svelte-check does not:

> svelte-check --tsconfig .\src\tsconfig.json
Debugger attached.

====================================
Loading svelte-check in workspace: c:\project
Getting Svelte diagnostics...

====================================
svelte-check found 0 errors and 0 warnings in 0 files

Proposed solution

fail if there were no files checked, as this almost certainly means there's an issue with your config

Alternatives

No response

Additional Information, eg. Screenshots

No response
@dummdidumm dummdidumm added feature request New feature or request good first issue Good for newcomers contributions welcome pull requests for this issue welcome labels Mar 23, 2023
@gustavojms
Copy link

Hey, i'm willing to take this implementation, can it be assigned to me? Also it will be helpful if possible to specify all files that need to be changed to make this enhancement.

@dummdidumm
Copy link
Member

Sure, go ahead! Change is likely scoped to inside getDiagnostics within packages/svelte-check/src/index.ts

@gustavojms gustavojms mentioned this issue Mar 25, 2023
Closed
dummdidumm added a commit to dummdidumm/language-tools that referenced this issue Apr 4, 2023
@dummdidumm
(feat) throw error on invalid tsconfig includes/excludes and on unkno…
94fcc7a 
…wn options

sveltejs#1952
sveltejs#1951
@dummdidumm dummdidumm mentioned this issue Apr 4, 2023
Merged
dummdidumm added a commit that referenced this issue Apr 4, 2023
@dummdidumm
(feat) throw error on invalid tsconfig includes/excludes and on unkno…
d5b29f0 
…wn options (#1974)

#1952
#1951
@dummdidumm dummdidumm added the Fixed Fixed in master branch. Pending production release. label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributions welcome pull requests for this issue welcome feature request New feature or request Fixed Fixed in master branch. Pending production release. good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dummdidumm @DetachHead @gustavojms