Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grave accent replacing instead of wrapping #264

Closed
subz390 opened this issue Jul 2, 2020 · 2 comments
Closed

Grave accent replacing instead of wrapping #264

subz390 opened this issue Jul 2, 2020 · 2 comments
Labels
feature request New feature or request Fixed Fixed in master branch. Pending production release.

Comments

@subz390
Copy link

subz390 commented Jul 2, 2020

` The Grave Accent

The editing actions of a Grave accent in Javascript sections of .svelte files within VSCode are not implemented.
By comparison the actions of single quotes '' and double quotes "", the grave accent is non-functioning.

Grave accents are required when working with Template Literals and an integral part of modern Javascript Svelte workflow.

There are two editing scenarios:

Expect: type the cymbol, it should print two and move the cursor between the two.
Actual one cymbol is printed

Expect select a range of code, type the cymbol, two cymbols are printed and the range moved between them.
grave accent - expected

Actual the range is deleted and one cymbol is printed
grave accent - actual

Environment

  • OS: Windows 10
  • IDE: VSCode
  • Plugin/Package: "Svelte for VSCode"

History

This is an old issue that was never address in the svelte-vscode plugin.

@subz390 subz390 added the bug Something isn't working label Jul 2, 2020
@dummdidumm dummdidumm added feature request New feature or request and removed bug Something isn't working labels Jul 2, 2020
dummdidumm pushed a commit to dummdidumm/language-tools that referenced this issue Jul 3, 2020
@dummdidumm dummdidumm added the Fixed Fixed in master branch. Pending production release. label Jul 3, 2020
@subz390
Copy link
Author

subz390 commented Jul 6, 2020

Thanks @dummdidumm when can we expect to see this filter through to Svelte for VS Code extension?

@dummdidumm
Copy link
Member

Released just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Fixed Fixed in master branch. Pending production release.
Projects
None yet
Development

No branches or pull requests

2 participants