Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Semantic Highlighting (Tokens) #71

Closed
icebr9 opened this issue May 8, 2020 · 0 comments
Closed

Add support for Semantic Highlighting (Tokens) #71

icebr9 opened this issue May 8, 2020 · 0 comments
Assignees
Labels
feature request New feature or request Fixed Fixed in master branch. Pending production release.

Comments

@icebr9
Copy link

icebr9 commented May 8, 2020

Is your feature request related to a problem? Please describe.
Implement semantic tokens so theme makers can apply Svelte-specific styling in their themes. (This is a feature since VSCode 1.43)
https://code.visualstudio.com/api/language-extensions/semantic-highlight-guide#theming
Following addition, guidelines/docs for theme makers should be added to the plugin description so they can target these tokens.

Describe the solution you'd like
Sample implementation can be found here, https://github.com/Microsoft/vscode-extension-samples/tree/master/semantic-tokens-sample

Describe alternatives you've considered
Make it a seperate optional plugin instead of integrating into Svelte Beta.

@dummdidumm dummdidumm added the feature request New feature or request label May 8, 2020
@jasonlyu123 jasonlyu123 self-assigned this Jan 7, 2021
dummdidumm pushed a commit that referenced this issue Jan 13, 2021
#71

This implements the semantic token for TypeScript. Because of TypeScript's implementation, this feature doesn't work with JavaScript.
@dummdidumm dummdidumm added the Fixed Fixed in master branch. Pending production release. label Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Fixed Fixed in master branch. Pending production release.
Projects
None yet
Development

No branches or pull requests

3 participants