(feat) event completion/hover for components with a type definition #1057
Conversation
|
W00t this is awesome! I was thinking about something like this recently (analyzing the TS AST ourselves) and now you open this PR 😄 I'll take a closer look later, excited for this! |
|
|
||
| return new JsOrTsComponentInfoProvider(typeChecker, classType); | ||
| } | ||
| } |
There was a problem hiding this comment.
What do you think about making the instance of this a property on TsOrJsDocumentSnapshot? Then it could be cached and the cache would only be deleted on updates to the snapshot.
There was a problem hiding this comment.
Not sure about the performance implications, but could this be something we could also use for the svelte2tsx-components? Then we could ditch our own implementation of creating the "events" property on the svelte2tsx return type.
There was a problem hiding this comment.
Cached in the snapshot seems like a good idea.
could this be something we could also use for the svelte2tsx-components
Yes. Tried with svelte2tsx-component. The biggest difference between this and the svelte2tsx approach is the fallback Event in the svelte2tsx.
|
Do you have time to add the caching logic the next few days or should I take over? This feature is too nice to not get it in as part of the next release 😄 |
|
OK. I'll add the caching logic soon |
…nto event-info-dts
Provide event hover info and completion for components with a type definition, mainly for components in component libraries.