(feat) use SvelteComponentTyped if exists #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check in svelteshims if we can use SvelteComponentTyped for more aligned typings This means invalid accessor calls are no longer caught, which is edge-case enough in my opinion so the benefits outweigh the drawbacks. In Svelte 4 this could be restricted in Svelte.
jasonlyu123
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check in svelteshims if we can use SvelteComponentTyped for more aligned typings
This means invalid accessor calls are no longer caught, which is edge-case enough in my opinion so the benefits outweigh the drawbacks. In Svelte 4 this could be restricted in Svelte. @jasonlyu123 what's your opinion on this?