-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) create sveltekit route files #1620
Conversation
From reading the bullet point list it sounds like we only need to do the |
I totally agree, it just adds unnecessary complexity. |
I also added some snippets for Edit: Not sure why but none of the snippets seem to work, even the svelte ones. |
cdf6e86
to
62730a5
Compare
"body": ["{#key ${1:key}}", "\t$TM_SELECTED_TEXT$0", "{/key}"], | ||
"description": "key block" | ||
"key block": { | ||
"prefix": "key", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefixes were deliberately left out in #1373 so they don't conflict with the language server completions. It sounds like you were wondering why they didn't show up, that's why. Could you revert this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this only affect the svelte snippets? The js and ts snippets don´t work for me without the prefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, only Svelte snippets
Apart from the snippet thing (prefix was omitted deliberatly) this seems like it's ready to review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Fixed one bug which made it fail on Windows, but that's all. Thank you so much for working on this 🎉
WorkspaceEdit
instead offs
find out if this is really a SvelteKit app (check package.json)