Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) better commit characters handling #1742

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Nov 29, 2022

#1737

  • no commit characters in invalid state in template
  • no commit characters when TS says it's isNewIdentifierLocation (matches VS Code behavior)

@dummdidumm dummdidumm changed the title (fix) no commit characters in invalid state in template (feat) better commit characters handling Nov 29, 2022
@dummdidumm dummdidumm merged commit 3a4c838 into sveltejs:master Nov 29, 2022
@dummdidumm dummdidumm deleted the completion-commit branch November 29, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant