Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rework bindable types strategy #2361

Merged
merged 5 commits into from
May 2, 2024
Merged

Commits on May 1, 2024

  1. fix: rework bindable types strategy

    Instead of using types that declare whether or not a type is bindable directly as part of the property, we're introducing a new for-types-only field to `SvelteComponent`: `$$bindings`, which is typed as the keys of the properties that are bindable (string by default, i.e. everything's bindable; for backwards compat). language-tools can then produce code that assigns to this property which results in an error we can display if the binding is invalid.
    This means we can revert a lot of the changes we made to make the previous version of bindable types work
    dummdidumm committed May 1, 2024
    Configuration menu
    Copy the full SHA
    8aa0a6e View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Configuration menu
    Copy the full SHA
    459bec9 View commit details
    Browse the repository at this point in the history
  2. rename fixes

    dummdidumm committed May 2, 2024
    Configuration menu
    Copy the full SHA
    5504814 View commit details
    Browse the repository at this point in the history
  3. fix test setup

    dummdidumm committed May 2, 2024
    Configuration menu
    Copy the full SHA
    4ffbf12 View commit details
    Browse the repository at this point in the history
  4. fix test

    dummdidumm committed May 2, 2024
    Configuration menu
    Copy the full SHA
    06306ba View commit details
    Browse the repository at this point in the history