Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) extract component refactoring #262

Merged
merged 6 commits into from
Jul 6, 2020
Merged

(feat) extract component refactoring #262

merged 6 commits into from
Jul 6, 2020

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Jul 2, 2020 •
edited

Simple version:

  • no semantic analysis if selection range is valid
  • no analysis which script/style code should be transferred

TODO

  • update import paths in new component

#187

Simon Holthausen added 5 commits July 2, 2020 10:48
(feat) extract component refactoring
da3d721 
sveltejs#187
(feat) extract component now with prompt for path/name
6ffc360 
- Is no longer part of the getCodeActions now, which might also improve performance a little
tests
f098c2d
docs
ac77698
lint
2bb1482
@dummdidumm dummdidumm marked this pull request as ready for review July 4, 2020 14:09
@dummdidumm dummdidumm merged commit 6f30321 into sveltejs:master Jul 6, 2020
@dummdidumm dummdidumm deleted the extract-component branch July 6, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dummdidumm