(feat) support default language of svelte-preprocess #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`svelte-preprocess` has a feature for setting default languages so you don't have to write `lang="x"` each time. This adds support for this in style/script tags. To accomplish this, parsing of the `svelte.config.js` was moved up to `Document`. Inside it, the `lang` attribute is set to the default language if there exists no `lang`/`type` attribute.
|
I did not change any dependencies and now build fails due to dependency errors... ? oO |
dummdidumm
force-pushed
the
default-language
branch
from
6c56834
to
f698927
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
svelte-preprocesshas a feature for setting default languages so you don't have to writelang="x"each time. This adds support for this in style/script tags.To accomplish this, parsing of the
svelte.config.jswas moved up toDocument. Inside it, thelangattribute is set to the default language if there exists nolang/typeattribute.I deliberately did not bump the
svelte-preprocessversion yet to wait until4.xhas received some more feedback and bugfixes.