(fix) mark props as optional in ts when no typings given #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, `export let a = ''` would not be marked as optional because it had no type. sveltejs#347 Also fixes a bug where file type was incorrectly inferred as jsx which occurs when user uses the default languages feature of svelte-preprocess. Instead of computing the file type inside svelte2tsx, it is now passed as an option.
dummdidumm
commented
Jul 27, 2020
| @@ -614,11 +614,7 @@ function processInstanceScriptContent(str: MagicString, script: Node): InstanceS | |||
| ts.forEachChild(list, (node) => { | |||
| if (ts.isVariableDeclaration(node)) { | |||
| if (ts.isIdentifier(node.name)) { | |||
| if (node.type) { | |||
There was a problem hiding this comment.
@halfnelson do you remember why you made this distinction? I removed it to enable optional props, but I fear I may have overlooked something else.
jasonlyu123
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this,
export let a = ''would not be marked as optional because it had no type.#347
Also fixes a bug where file type was incorrectly inferred as jsx which occurs when user uses the default languages feature of svelte-preprocess. Instead of computing the file type inside svelte2tsx, it is now passed as an option.