Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) remove svelte from typings, add it to every svelte2tsx output instead #441

Merged

Conversation

dummdidumm
Copy link
Member

Less setup for people ("types": ["svelte"] now obsolete), makes TS search more of the other globals.
#430

Simon Holthausen added 3 commits August 10, 2020 19:47
…nstead

Less setup for people (`"types": ["svelte"]` now obsolete), makes TS search more of the other globals.
sveltejs#430
Copy link
Member

@jasonlyu123 jasonlyu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dummdidumm dummdidumm merged commit 5478142 into sveltejs:master Aug 11, 2020
@dummdidumm dummdidumm deleted the marke-tsconfig-svelte-types-obsolete branch August 11, 2020 07:27
dummdidumm added a commit to dummdidumm/bases that referenced this pull request Aug 12, 2020
Was necessary to get completions for things such as `onMount`. Obsolete now because of this PR sveltejs/language-tools#441 which adds the typings through `///` at the top of every svelte2tsx file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants