do not suggest lang when editing attributes

[tanhauhau]

Before

After

[tanhauhau]

how do i add test for this?

[jasonlyu123]

You can have a test similar to this one

language-tools/packages/language-server/test/plugins/html/HTMLPlugin.test.ts

Line 41 in 9f9fef9

it('provides completions', async () => {

setup('<div sty') and filter the return list see if lang completion exists

[dummdidumm]

Note: You need to merge the changes from master in and do yarn install again, yarn.lock and tests have changed.

[dummdidumm]

I noticed there is an easier (and possibly more performant) way to fix this:

The completion for tags has CompletionItemKind.Property, while the completion for attributes has CompletionItemKind.Value. So we can just enhance the filter like this

const styleScriptTemplateCompletions = completions.filter((completion) =>
     completion.kind === CompletionItemKind.Property && ['template', 'style', 'script'].includes(completion.label),
;

[tanhauhau]

ok , updated the branch and added test case

[dummdidumm]

Nice!

[dummdidumm]

That's a great optimization!