(chore) bump ts to 4.0, fix build/tests #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dummdidumm
commented
Aug 21, 2020
dummdidumm
commented
- Change in CSSDocument necessary to avoid new "is defined as a property in class '..', but is overridden here in '..' as an accessor" error
- Changes in tests necessary because diagnostics + refactoring order changed slightly
- Also removed some duplicated tests
added 2 commits
August 21, 2020 08:37
- Change in CSSDocument necessary to avoid new "is defined as a property in class '..', but is overridden here in '..' as an accessor" error - Changes in tests necessary because diagnostics + refactoring order changed slightly - Also removed some duplicated tests
The new rule "@typescript-eslint/explicit-module-boundary-types" caused many warnings, therefore disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.