Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) multi folders in workspace #480

Merged
merged 3 commits into from Aug 26, 2020
Merged

(fix) multi folders in workspace #480

merged 3 commits into from Aug 26, 2020

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented Aug 26, 2020

Currently, Svelte Language Server doesn't work well when there're multiple folders in a workspace. This PR fixes it.

Hope to be merged.

Copy link
Member

@jasonlyu123 jasonlyu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly you are trying to support multi-root-workspaces?

packages/language-server/src/server.ts Outdated Show resolved Hide resolved
@g-plane
Copy link
Contributor Author

g-plane commented Aug 26, 2020

Are there any other problems which should be addressed?

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dummdidumm dummdidumm merged commit 9abbe19 into sveltejs:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants