Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set compilerOptions.css to 'external' when emitCss was true #211

Merged
merged 5 commits into from
Jun 26, 2023

Conversation

gucheen
Copy link
Contributor

@gucheen gucheen commented Jun 26, 2023

to remove below warning

compilerOptions.css as a boolean is deprecated. Use 'external' instead of false.

set css to 'external' while svelte version >= 4

latest svelte compiler has changed css option values to

css?: 'injected' | 'external' | 'none' | boolean;

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think it's easier to simplify this to just check for version 3 since it's backwards compatible in that. Makes the code a bit easier to reason about. Could you adjust the code accordingly? Then we're good to merge 👍

@gucheen
Copy link
Contributor Author

gucheen commented Jun 26, 2023

Thank you! I think it's easier to simplify this to just check for version 3 since it's backwards compatible in that. Makes the code a bit easier to reason about. Could you adjust the code accordingly? Then we're good to merge 👍

I have adjust the version checking to majorVer > 3(start from svelte v4) @dummdidumm

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit 8b5c16d into sveltejs:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants