Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 'front-matter' for parsing front matter #30

Open
swyxio opened this issue Sep 14, 2019 · 0 comments
Open

use 'front-matter' for parsing front matter #30

swyxio opened this issue Sep 14, 2019 · 0 comments

Comments

@swyxio
Copy link
Contributor

swyxio commented Sep 14, 2019

Describe the bug

generate_docs uses site-kit, which uses a homecooked front matter parser. however this is non standard frontmatter:

this:

title: "Scooby Doo: Where are you"
published: false

should parse to:

{
	"title": "Scooby Doo: Where are you",
	"published": false
}

whereas with site-kit this happens:

{
	"title": "\"Scooby Doo: Where are you\"",
	"published": "false"
}

which causes nasty bugs down the line.

front-matter exists, we should use and encourage it.

i dont know if a formal frontmatter spec exists, but from experience this behavior is fairly standard now.

if you accept this i am happy to submit a PR but i am holding off because i'm sensing a PR backlog.

@Conduitry Conduitry transferred this issue from sveltejs/sapper Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant