Improve color contrast of syntax highlighting #185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The color contrast of the syntax highlighting in the code samples did not meet WCAG AA standards (4.5 for small text), which could make it hard to read for people with low vision. This PR updates the colors used to match that threshold. This reduces the count of color contrast Axe violations to 233 from 1493 instances.
Contrast changes (checked using https://contrast-ratio.com with #f6fafd background):
Before:
![image](https://user-images.githubusercontent.com/4992896/146418888-6afad3fd-b78a-4ee9-9dae-8edbdd8b66e5.png)
After:
![image](https://user-images.githubusercontent.com/4992896/146418798-60dda2e5-a86d-4a1a-9fd5-3fa25534f065.png)
I made a similar PR against the old site repo (sveltejs/svelte#5681), but it looks like those changes got lost at some point in the migration. This PR uses those changes as a base but leaves all colors as HSL and does not change tokens that now meet the 4.5 threshold.