feat: specify add-on id #192
Conversation
|
|
||
| "browser_specific_settings": { | ||
| "gecko": { | ||
| "id": "firefox-devtools@svelte.dev", |
There was a problem hiding this comment.
This feels a bit long and so doesn't look that nice to me when written out. How about just svelte.dev?
There was a problem hiding this comment.
I might've tried that and it failed as it needs to either be a GUID or string formatted like an email address per https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_specific_settings#firefox_gecko_properties
I can try and see if @svelte.dev works by tomorrow
There was a problem hiding this comment.
Ah, interesting. If we have to use a @ then I might suggest devtools@svelte.dev. Just @svelte.dev looks a bit funny to me
There was a problem hiding this comment.
I did use devtools@svelte.dev at first when I tried to publish it on addons.mozilla.org, but it conflicts with the old one as we discussed in Discord. Reuploading it for the "distributing on your own" doesn't work since the ID has been registered, and we can't reuse the ID according to their policy, so we need another unique ID
It does seem like it's only used internally, so a random GUID like "{daf44bf7-a45e-4450-979c-91cf07434c3d}" would also do the job, and @svelte.dev seems to work too if we want to opt for a really short one.
P.S. I did a test run and submitted this to see if there's any other issue, and I just got the confirmation for the extension submitted with firefox-devtools@svelte.dev has been approved and signed. We can do another reupload with a different ID to finalize this if it ends up different.
There was a problem hiding this comment.
Oh, I thought it was just plain svelte that the old one was using as it's id
There was a problem hiding this comment.
Alright, I'll merge this so that we can get a signed add-on install file for Firefox on the next release
Necessary for #190