Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update svelte to 5.0.0-next.115 && minor refactor #513

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Conversation

ota-meshi
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Apr 28, 2024

🦋 Changeset detected

Latest commit: 23e66bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-eslint-parser Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

return {
type: "SvelteOptions",
name: "svelte:options",
attributes: root.options.attributes,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SvelteOptions node now provides attributes so we don't have to parse it ourselves.

@coveralls
Copy link

coveralls commented Apr 28, 2024

Pull Request Test Coverage Report for Build 8866265745

Details

  • 5 of 7 (71.43%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 90.733%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/typescript/analyze/index.ts 1 3 33.33%
Totals Coverage Status
Change from base Build 8802234292: 0.2%
Covered Lines: 2793
Relevant Lines: 2968

💛 - Coveralls

@ota-meshi ota-meshi merged commit 37f0061 into main Apr 29, 2024
13 checks passed
@ota-meshi ota-meshi deleted the update branch April 29, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants