Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issues/336: typescript: importing component from pnpm monorepo p… #337

Merged
merged 3 commits into from
May 3, 2021

Conversation

btakita
Copy link
Contributor

@btakita btakita commented Mar 29, 2021

fixes #336

@btakita
Copy link
Contributor Author

btakita commented Mar 29, 2021

I'm not sure if resolving from process.cwd() is correct. I made an "educated guess" & this happens to fix the build on my project.

@ashpieboop
Copy link

In my setup, some files are passed with relative path, no leading ./ (example: build/views/home_dep.svelte) so I believe your fix is incomplete.

src/transformers/typescript.ts Outdated Show resolved Hide resolved
src/transformers/typescript.ts Outdated Show resolved Hide resolved
@kaisermann
Copy link
Member

@btakita Thanks for the contribution! However, I think that the last rebase/merge done added quite a few of undesired commits to the commit history of this branch 🤔

@btakita
Copy link
Contributor Author

btakita commented Apr 21, 2021

@kaisermann np, I will remove them. I was confused why they appeared from the github origin

@kaisermann
Copy link
Member

@btakita There were still some extra commits there. I took the liberty of rewriting the branch's commit history. Could you check if the code is still as it should? If yes, we're good to go 👍

@btakita
Copy link
Contributor Author

btakita commented Apr 28, 2021

@kaisermann lgtm. Thank you for removing those commits.

@kaisermann kaisermann merged commit bf72637 into sveltejs:main May 3, 2021
@kaisermann
Copy link
Member

kaisermann commented May 3, 2021

Released in 4.7.3 🎉 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants