chore: remove form from interactive elements and add specific check

sveltejs · Jun 6, 2024 · 134fcad · 134fcad
1 parent 776e837
commit 134fcad
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/packages/svelte/src/compiler/phases/2-analyze/validation.js b/packages/svelte/src/compiler/phases/2-analyze/validation.js
@@ -568,6 +568,17 @@ const validation = {
 			}
 		}
 
+		// can't add form to interactive elements because those are also used by the parser
+		// to check for the last auto-closing parent.
+		if (node.name === 'form') {
+			const path = context.path;
+			for (let parent of path) {
+				if (parent.type === 'RegularElement' && parent.name === 'form') {
+					e.node_invalid_placement(node, `<${node.name}>`, parent.name);
+				}
+			}
+		}
+
 		if (interactive_elements.has(node.name)) {
 			const path = context.path;
 			for (let parent of path) {

diff --git a/packages/svelte/src/constants.js b/packages/svelte/src/constants.js
@@ -118,8 +118,7 @@ export const interactive_elements = new Set([
 	'iframe',
 	'embed',
 	'select',
-	'textarea',
-	'form'
+	'textarea'
 ]);
 
 export const disallowed_paragraph_contents = [