fix: more robust url equality check at dev time

fixes #10021
sveltejs · Jan 24, 2024 · 14d7b26 · 14d7b26
1 parent a476e81
commit 14d7b26
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/.changeset/gentle-spies-happen.md b/.changeset/gentle-spies-happen.md
@@ -0,0 +1,5 @@
+---
+"svelte": patch
+---
+
+fix: more robust url equality check at dev time
diff --git a/packages/svelte/src/internal/client/render.js b/packages/svelte/src/internal/client/render.js
@@ -2295,22 +2295,14 @@ export function attr(dom, attribute, value) {
 	}
 }
 
-/** @type {HTMLAnchorElement | undefined} */
-let src_url_equal_anchor;
-
 /**
  * @param {string} element_src
  * @param {string} url
  * @returns {boolean}
  */
 function src_url_equal(element_src, url) {
 	if (element_src === url) return true;
-	if (!src_url_equal_anchor) {
-		src_url_equal_anchor = document.createElement('a');
-	}
-	// This is actually faster than doing URL(..).href
-	src_url_equal_anchor.href = url;
-	return element_src === src_url_equal_anchor.href;
+	return new URL(element_src, document.baseURI).href === new URL(url, document.baseURI).href;
 }
 
 /** @param {string} srcset */