fix: relax constraint for ComponentProps

`Component` with any props should be allowed to pass in
sveltejs · Jun 13, 2024 · 15ef157 · 15ef157
1 parent 0119f25
commit 15ef157
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/.changeset/clean-melons-wash.md b/.changeset/clean-melons-wash.md
@@ -0,0 +1,5 @@
+---
+"svelte": patch
+---
+
+fix: relax constraint for `ComponentProps`
diff --git a/packages/svelte/src/index.d.ts b/packages/svelte/src/index.d.ts
@@ -198,7 +198,7 @@ export type ComponentEvents<Comp extends SvelteComponent> =
  * </script>
  * ```
  */
-export type ComponentProps<Comp extends SvelteComponent | Component> =
+export type ComponentProps<Comp extends SvelteComponent | Component<any>> =
 	Comp extends SvelteComponent<infer Props>
 		? Props
 		: Comp extends Component<infer Props>

diff --git a/packages/svelte/tests/types/component.ts b/packages/svelte/tests/types/component.ts
@@ -231,6 +231,13 @@ functionComponentInstance.foo === 'bar';
 // @ts-expect-error
 functionComponentInstance.foo = 'foo';
 
+const functionComponentProps: ComponentProps<typeof functionComponent> = {
+	binding: true,
+	readonly: 'foo',
+	// @ts-expect-error
+	prop: 1
+};
+
 mount(functionComponent, {
 	target: null as any as Document | Element | ShadowRoot,
 	props: {

diff --git a/packages/svelte/types/index.d.ts b/packages/svelte/types/index.d.ts
@@ -195,7 +195,7 @@ declare module 'svelte' {
 	 * </script>
 	 * ```
 	 */
-	export type ComponentProps<Comp extends SvelteComponent | Component> =
+	export type ComponentProps<Comp extends SvelteComponent | Component<any>> =
 		Comp extends SvelteComponent<infer Props>
 			? Props
 			: Comp extends Component<infer Props>