Merge pull request #3333 from Conduitry/gh-3179

preserve async/generator-ness of hoisted function expressions
sveltejs · Aug 3, 2019 · 21e3db1 · 21e3db1
2 parents 76d04dc + bfa0bc9
commit 21e3db1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/src/compiler/compile/nodes/shared/Expression.ts b/src/compiler/compile/nodes/shared/Expression.ts
@@ -363,7 +363,7 @@ export default class Expression {
 					}
 
 					const fn = deindent`
-						function ${name}(${args.join(', ')}) ${body}
+						${node.async && 'async '}function${node.generator && '*'} ${name}(${args.join(', ')}) ${body}
 					`;
 
 					if (dependencies.size === 0 && contextual_dependencies.size === 0) {

diff --git a/test/runtime/samples/event-handler-async/_config.js b/test/runtime/samples/event-handler-async/_config.js
@@ -0,0 +1,5 @@
+export default {
+	html: `
+		<button>nothing</button>
+	`,
+};
diff --git a/test/runtime/samples/event-handler-async/main.svelte b/test/runtime/samples/event-handler-async/main.svelte
@@ -0,0 +1 @@
+<button on:click={async () => { await null; }}>nothing</button>