fix: allow child element with slot attribute within svelte:element

sveltejs · Jul 25, 2023 · 68b8793 · 68b8793
1 parent a71f359
commit 68b8793
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 1 deletion.
diff --git a/.changeset/nine-houses-flow.md b/.changeset/nine-houses-flow.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: allow child element with slot attribute within svelte:element
diff --git a/packages/svelte/src/compiler/compile/nodes/Element.js b/packages/svelte/src/compiler/compile/nodes/Element.js
@@ -1414,7 +1414,9 @@ const regex_minus_sign = /-/;
 function within_custom_element(parent) {
 	while (parent) {
 		if (parent.type === 'InlineComponent') return false;
-		if (parent.type === 'Element' && regex_minus_sign.test(parent.name)) return true;
+		if (parent.type === 'Element') {
+			if (regex_minus_sign.test(parent.name) || parent.is_dynamic_element) return true;
+		}
 		parent = parent.parent;
 	}
 	return false;

diff --git a/packages/svelte/test/runtime/samples/slot-in-dynamic-element/_config.js b/packages/svelte/test/runtime/samples/slot-in-dynamic-element/_config.js
@@ -0,0 +1,7 @@
+export default {
+	html: `
+		<dynamic-element>
+			<header slot='header'>header header header</header>
+		</dynamic-element>
+	`
+};
diff --git a/packages/svelte/test/runtime/samples/slot-in-dynamic-element/main.svelte b/packages/svelte/test/runtime/samples/slot-in-dynamic-element/main.svelte
@@ -0,0 +1,7 @@
+<script>
+	export let tagName = 'dynamic-element'
+</script>
+
+<svelte:element this={tagName}>
+	<header slot='header'>header header header</header>
+</svelte:element>