Skip to content

Commit

Permalink
fix: add GamepadEventHandler type (#9864)
Browse files Browse the repository at this point in the history
Add GamepadEventHandler type for window.addEventListener `gamepadconnected` and `gamepaddisconnected`
  • Loading branch information
ntsd committed Dec 11, 2023
1 parent b1795a8 commit 804f296
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/fair-eagles-wink.md
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: add `gamepadconnected` and `gamepaddisconnected` events
7 changes: 6 additions & 1 deletion packages/svelte/elements.d.ts
Expand Up @@ -53,6 +53,7 @@ export type KeyboardEventHandler<T extends EventTarget> = EventHandler<KeyboardE
export type MouseEventHandler<T extends EventTarget> = EventHandler<MouseEvent, T>;
export type TouchEventHandler<T extends EventTarget> = EventHandler<TouchEvent, T>;
export type PointerEventHandler<T extends EventTarget> = EventHandler<PointerEvent, T>;
export type GamepadEventHandler<T extends EventTarget> = EventHandler<GamepadEvent, T>;
export type UIEventHandler<T extends EventTarget> = EventHandler<UIEvent, T>;
export type WheelEventHandler<T extends EventTarget> = EventHandler<WheelEvent, T>;
export type AnimationEventHandler<T extends EventTarget> = EventHandler<AnimationEvent, T>;
Expand Down Expand Up @@ -170,6 +171,10 @@ export interface DOMAttributes<T extends EventTarget> {
'on:pointerup'?: PointerEventHandler<T> | undefined | null;
'on:lostpointercapture'?: PointerEventHandler<T> | undefined | null;

// Gamepad Events
'on:gamepadconnected'?: GamepadEventHandler<T> | undefined | null;
'on:gamepaddisconnected'?: GamepadEventHandler<T> | undefined | null;

// UI Events
'on:scroll'?: UIEventHandler<T> | undefined | null;
'on:resize'?: UIEventHandler<T> | undefined | null;
Expand Down Expand Up @@ -1454,7 +1459,7 @@ export interface SVGAttributes<T extends EventTarget> extends AriaAttributes, DO
z?: number | string | undefined | null;
zoomAndPan?: string | undefined | null;

// allow any data- attribute
// allow any data- attribute
[key: `data-${string}`]: any;
}

Expand Down

0 comments on commit 804f296

Please sign in to comment.