fix: allow bind:this with dynamic type on inputs

fixes #9709
sveltejs · Nov 30, 2023 · 85a3215 · 85a3215
1 parent bde42d5
commit 85a3215
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/great-icons-retire.md b/.changeset/great-icons-retire.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: allow `bind:this` with dynamic type on inputs
diff --git a/packages/svelte/src/compiler/phases/2-analyze/validation.js b/packages/svelte/src/compiler/phases/2-analyze/validation.js
@@ -323,7 +323,7 @@ export const validation = {
 					);
 				}
 
-				if (parent.name === 'input') {
+				if (parent.name === 'input' && node.name !== 'this') {
 					const type = /** @type {import('#compiler').Attribute | undefined} */ (
 						parent.attributes.find((a) => a.type === 'Attribute' && a.name === 'type')
 					);

diff --git a/packages/svelte/tests/validator/samples/binding-this-input-type-dynamic/errors.json b/packages/svelte/tests/validator/samples/binding-this-input-type-dynamic/errors.json
@@ -0,0 +1 @@
+[]
diff --git a/packages/svelte/tests/validator/samples/binding-this-input-type-dynamic/input.svelte b/packages/svelte/tests/validator/samples/binding-this-input-type-dynamic/input.svelte
@@ -0,0 +1,6 @@
+<script>
+	let foo;
+	let inputType;
+</script>
+
+<input bind:this={foo} type={inputType}>