fix: ensure keyed fallback to indexed (#9441)

Fixes #9408. Ensures that if we have a key that matches the index, that we fallback to using an indexed each block.
sveltejs · Nov 14, 2023 · cf63220 · cf63220 · vercel · Nov 14, 2023
1 parent da37c92
commit cf63220
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 1 deletion.
diff --git a/.changeset/honest-icons-change.md b/.changeset/honest-icons-change.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+patch: ensure keyed each block fallback to indexed each block
diff --git a/packages/svelte/src/compiler/phases/3-transform/client/visitors/template.js b/packages/svelte/src/compiler/phases/3-transform/client/visitors/template.js
@@ -2066,7 +2066,10 @@ export const template_visitors = {
 		/** @type {number} */
 		let each_type;
 
-		if (node.key) {
+		if (
+			node.key &&
+			(node.key.type !== 'Identifier' || !node.index || node.key.name !== node.index)
+		) {
 			each_type = EACH_KEYED;
 			if (
 				node.key.type === 'Identifier' &&

diff --git a/packages/svelte/tests/runtime-legacy/samples/keyed-each-index-same/_config.js b/packages/svelte/tests/runtime-legacy/samples/keyed-each-index-same/_config.js
@@ -0,0 +1,5 @@
+import { test } from '../../test';
+
+export default test({
+	html: '1'
+});
diff --git a/packages/svelte/tests/runtime-legacy/samples/keyed-each-index-same/main.svelte b/packages/svelte/tests/runtime-legacy/samples/keyed-each-index-same/main.svelte
@@ -0,0 +1,3 @@
+{#each [1] as item, i (i)}
+	{item}
+{/each}