treat slot the same as other props - closes #9455 (#9457)

Co-authored-by: Rich Harris <rich.harris@vercel.com>
sveltejs · Nov 15, 2023 · f5101c0 · f5101c0 · vercel · Nov 15, 2023
1 parent 6f6c3a0
commit f5101c0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/.changeset/tiny-kings-whisper.md b/.changeset/tiny-kings-whisper.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: treat `slot` the same as other props
diff --git a/packages/svelte/src/compiler/phases/3-transform/client/visitors/template.js b/packages/svelte/src/compiler/phases/3-transform/client/visitors/template.js
@@ -710,7 +710,6 @@ function serialize_inline_component(node, component_name, context) {
 		} else if (attribute.type === 'SpreadAttribute') {
 			props_and_spreads.push(/** @type {import('estree').Expression} */ (context.visit(attribute)));
 		} else if (attribute.type === 'Attribute') {
-			if (attribute.name === 'slot') continue;
 			if (attribute.name.startsWith('--')) {
 				custom_css_props.push(
 					b.init(attribute.name, serialize_attribute_value(attribute.value, context)[1])

diff --git a/packages/svelte/src/compiler/phases/3-transform/server/transform-server.js b/packages/svelte/src/compiler/phases/3-transform/server/transform-server.js
@@ -782,7 +782,6 @@ function serialize_inline_component(node, component_name, context) {
 		} else if (attribute.type === 'SpreadAttribute') {
 			props_and_spreads.push(/** @type {import('estree').Expression} */ (context.visit(attribute)));
 		} else if (attribute.type === 'Attribute') {
-			if (attribute.name === 'slot') continue;
 			if (attribute.name.startsWith('--')) {
 				const value = serialize_attribute_value(attribute.value, context, false, true);
 				custom_css_props.push(b.init(attribute.name, value));