Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte 5: ::view-transition-old is not a valid CSS identifier #10019

Closed
ayroblu opened this issue Dec 29, 2023 · 1 comment · Fixed by #10055
Closed

Svelte 5: ::view-transition-old is not a valid CSS identifier #10019

ayroblu opened this issue Dec 29, 2023 · 1 comment · Fixed by #10055
Labels

Comments

@ayroblu
Copy link

ayroblu commented Dec 29, 2023

Describe the bug

I was trying to try view transitions, and I couldn't get my vite svelte server to compile.

Internal server error: /path/to/project/src/routes/component-name/+page.svelte:95:28 Expected a valid CSS identifier
  Plugin: vite-plugin-svelte
  File: /path/to/project/src/routes/component/+page.svelte:95:28
  94 |      view-transition-name: component-name;
  95 |    }
  96 |    :root::view-transition-old(component-name),
     |                          ^
  97 |    :root::view-transition-new(component-name) {
  98 |      animation-delay: 5s;

I feel like I'm doing it wrong cause I see it used in this blog post, so maybe a regression or I'm just doing something wrong

Reproduction URL

I can add this if this is actually an issue and not just a dumb mistake on my part

Reproduction

No response

Logs

No response

System Info

System:
    OS: macOS 14.1.2
    CPU: (8) arm64 Apple M1 Pro
    Memory: 55.55 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 21.3.0 - /opt/homebrew/bin/node
    Yarn: 1.22.17 - /usr/local/bin/yarn
    npm: 8.19.3 - /usr/local/bin/npm
  Browsers:
    Chrome: 120.0.6099.129
    Edge: 113.0.1774.42
    Safari: 17.1.2
  npmPackages:
    @sveltejs/adapter-auto: ^3.0.0 => 3.0.1
    @sveltejs/adapter-static: ^3.0.1 => 3.0.1
    @sveltejs/kit: ^2.0.0 => 2.0.6
    @sveltejs/vite-plugin-svelte: ^3.0.0 => 3.0.1
    svelte: ^5.0.0-next.1 => 5.0.0-next.26
    vite: ^5.0.3 => 5.0.10
@Conduitry Conduitry transferred this issue from sveltejs/vite-plugin-svelte Dec 29, 2023
@Conduitry Conduitry changed the title ::view-transition-old is not a valid CSS identifier Svelte 5: ::view-transition-old is not a valid CSS identifier Dec 29, 2023
@iamjuney
Copy link

i thought i was the only one 🥲

dummdidumm added a commit that referenced this issue Jan 2, 2024
closes #9398 (the other things in that issue are already addressed)
closes #10019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants