-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Svelte 5: (non-state-reference) moduleVariable
is updated, but is not declared with $state(...)...
#11269
Comments
What is the desired behavior here? |
First of all, I'm not sure why this would be flagged as an error/warning, since it's just passed to the component as a property and there are no reactive updates that depend on it. You can see that if you move the variable to a non-module script, the error disappears: Svelte5-REPL Secondly, I don't know why it's flagged as a different level of error in
I'm not sure what you mean, but I think minimal reproduction is enough to illustrate the problem, I'm not sure what you're looking for. If you don't think the issues exist there, feel free to close the issue. |
I can't help you with the eslint case (it may be that the default is to error on these warnings). As for the warning itself, this is a non-runes file in which this error shouldn't appear.
What I mean is: Your reproduction is too minimal. Surely you didn't write code like this in your real app, so I'd like to see a more realistic, less minimal example to understand whether this is a false positive or not. |
Sorry, I still don't understand what you're saying, this is a minimal reproduction of the code from my REAL app. I don't have time to make up code that doesn't exist to flood(?!) the repo. In fact it is a very complex object, so adding any non-relevant code will cause a huge increase in complexity. I don't want to throw the whole app at you, and I can't. I also don't want to make an extra complicated reproduction for this. I've spent a lot of time investigating and making this minimal reproduction. It's effective and straightforward. I'm guessing you're looking to see if it's being used as a reactive variable elsewhere, but you shouldn't, in this reproduction it's not, so it shouldn't be a warning, right? Also yes, it's not a rune file, it's code come from Svelte 4.
Maybe it should be forwarded to the If you can't reproduce it locally, I could try replicating the project environment, but are you saying you're not interested in investigating that at all? |
Ok it's a non runes files so #11434 will fix this |
Describe the bug
Refer to the reproduction below.
It's worth noting that this is reported as
error
rather thanwarn
ineslint-svelte
.I don't know why it just shows up as
warn
in the source andREPL
.In other words, it shows up as a red wavy line in local VSCode.
Reproduction
Svelte5-REPL
Logs
No response
System Info
Severity
blocking an upgrade
The text was updated successfully, but these errors were encountered: