Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if inside keyed each - state is undefined #1202

Closed
Conduitry opened this issue Mar 5, 2018 · 1 comment · Fixed by #1204
Closed

if inside keyed each - state is undefined #1202

Conduitry opened this issue Mar 5, 2018 · 1 comment · Fixed by #1204
Labels
bug

Comments

@Conduitry
Copy link
Member

https://svelte.technology/repl?version=1.56.1&gist=2b04ce441cdb48cb0d4277db0d94b9ff

If a keyed EachBlock contains an IfBlock, it is called only with create_if_block(component, state), while in the function's definition it expects create_if_block(component, key, state).

The each being keyed seems to be necessary for reproducing this, but I haven't looked much into what other situations this affects or what might be causing it.
@Conduitry Conduitry added the bug label Mar 5, 2018
@Rich-Harris
Copy link
Member

I have a fix for this — PR inbound

Rich-Harris added a commit that referenced this issue Mar 5, 2018
@Rich-Harris
only apply key to keyed each block, not its children - fixes #1202
7b4c486
@Rich-Harris Rich-Harris mentioned this issue Mar 5, 2018
Merged
Rich-Harris added a commit that referenced this issue Mar 5, 2018
@Rich-Harris
Merge pull request #1204 from sveltejs/gh-1202
0599b5f 
only apply key to keyed each block, not its children
This was referenced Mar 14, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

only apply key to keyed each block, not its children sveltejs/svelte
2 participants
@Rich-Harris @Conduitry