Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development warnings #13

Closed
Rich-Harris opened this issue Nov 21, 2016 · 4 comments
Closed

Development warnings #13

Rich-Harris opened this issue Nov 21, 2016 · 4 comments
Milestone

Comments

@Rich-Harris
Copy link
Member

There are a few things that can't be caught with static analysis, such as missing data on first render. Is better if we only check those things in development mode, since it's unnecessary code in production otherwise.

@PaulBGD
Copy link
Member

PaulBGD commented Feb 11, 2017

Would this be a check like if (process.env.NODE_ENV !== 'production') ?

@Rich-Harris
Copy link
Member Author

Something like that, yes — or maybe a compile option, like

const { code, map } = svelte.compile( template, {
  dev: true
});

@PaulBGD
Copy link
Member

PaulBGD commented Mar 1, 2017

I think I've gotten too used to working with view frameworks.

@Rich-Harris Rich-Harris added this to the ASAP milestone Mar 1, 2017
Rich-Harris added a commit that referenced this issue Mar 1, 2017
add development warnings for missing data properties
@Rich-Harris
Copy link
Member Author

Implemented in 1.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants