Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onstate: changed is empty if data property not mentioned in template #1356

Closed
aphitiel opened this issue Apr 20, 2018 · 1 comment
Closed

onstate: changed is empty if data property not mentioned in template #1356

aphitiel opened this issue Apr 20, 2018 · 1 comment
Labels
bug

Comments

@aphitiel
Copy link
Contributor

REPL contains just a property test and an onstate listener.

onstate fires, but changed is empty. If test is used in the template, changed is {test: 1}, as expected.
aphitiel added a commit to aphitiel/svelte that referenced this issue Apr 22, 2018
@aphitiel
Failing test for sveltejs#1356
00fb978
Rich-Harris added a commit that referenced this issue Apr 22, 2018
@Rich-Harris
Merge branch 'master' into gh-1356
0bc6828
Rich-Harris added a commit that referenced this issue Apr 22, 2018
@Rich-Harris
correctly report changed properties in initial state/update events - f…
991bd9d 
…ixes #1356
@Rich-Harris Rich-Harris mentioned this issue Apr 22, 2018
Merged
Rich-Harris added a commit that referenced this issue Apr 22, 2018
@Rich-Harris
Merge branch 'master' into gh-1356
a42c1e4
Rich-Harris added a commit that referenced this issue Apr 22, 2018
@Rich-Harris
Merge pull request #1364 from sveltejs/gh-1356
6534fef 
Report initial `changed` based on state, not expected properties
@Rich-Harris
Copy link
Member

This is fixed in 2.1.1, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rich-Harris @aphitiel