Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canvas ref not working in div #1407

Closed
stalkerg opened this issue May 3, 2018 · 2 comments
Closed

Canvas ref not working in div #1407

stalkerg opened this issue May 3, 2018 · 2 comments

Comments

@stalkerg
Copy link
Contributor

stalkerg commented May 3, 2018 •
edited
Loading

Subj, a small modified example from the documentation:
https://svelte.technology/repl?version=2.4.2&gist=b06728bb9e129364fe7cd9e514275843

the problem started with 2.2.0 version.
This ref just not exist in a component.refs object.
@Conduitry
Copy link
Member

Looks like we're not correctly recognizing that we can't use the static .innerHTML shortcut when there's a ref. Element#init needs some code to the effect of if (this.ref) this.parent.cannotUseInnerHTML();.

Conduitry added a commit that referenced this issue May 3, 2018
@Conduitry
mark elements with refs as ineligible for innerhtml (#1407)
aba5929
@Conduitry Conduitry mentioned this issue May 3, 2018
Merged
Rich-Harris added a commit that referenced this issue May 3, 2018
@Rich-Harris
Merge pull request #1408 from sveltejs/gh-1407
ea95ae7 
mark elements with refs as ineligible for innerhtml
@Rich-Harris
Copy link
Member

released 2.4.3 with the fix — thanks

red8012 added a commit to akimous/akimous that referenced this issue Nov 13, 2019
@red8012
DEP: as svelte fixed sveltejs/svelte#1407, remove redundent directives
6b33abf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Rich-Harris @stalkerg @Conduitry