Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested transitions cause inputs to lose focus #1527

Closed
Rich-Harris opened this issue Jun 6, 2018 · 0 comments · Fixed by #1529
Closed

Nested transitions cause inputs to lose focus #1527

Rich-Harris opened this issue Jun 6, 2018 · 0 comments · Fixed by #1529
Labels
bug

Comments

@Rich-Harris
Copy link
Member

See the REPL.

It looks like the issue is that the <input> is getting remounted because the if block's intro method is being called, and there's no check in place to ensure that it's necessary to do so
@Rich-Harris Rich-Harris added the bug label Jun 6, 2018
Rich-Harris added a commit that referenced this issue Jun 6, 2018
@Rich-Harris
failing test for #1527
52032be
@Rich-Harris Rich-Harris mentioned this issue Jun 6, 2018
Merged
Rich-Harris added a commit that referenced this issue Jun 8, 2018
@Rich-Harris
Merge pull request #1529 from sveltejs/gh-1527
b76f074 
avoid unnecessary remounts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

avoid unnecessary remounts sveltejs/svelte
1 participant
@Rich-Harris