Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{#each x as x} with bind: mutates x #1565

Closed
aphitiel opened this issue Jun 27, 2018 · 1 comment · Fixed by #3698
Closed

{#each x as x} with bind: mutates x #1565

aphitiel opened this issue Jun 27, 2018 · 1 comment · Fixed by #3698
Labels
bug

Comments

@aphitiel
Copy link
Contributor

Using {#each x as x} is not only stupid, it's also dangerous, as this REPL shows.

If you type into any input, data.x changes from array to an element of itself. I think the compiler could either guard against this or leave my data alone and just let me write the occasional dumb code.
@Rich-Harris
Copy link
Member

Still an issue in v3, it appears https://svelte.dev/repl?version=3.0.0-beta.28&gist=9e5d6b7611c5585923b975c4e2b6f090

@Conduitry Conduitry added the bug label Jul 27, 2019
@tanhauhau tanhauhau mentioned this issue Oct 12, 2019
Merged
4 tasks
Conduitry pushed a commit that referenced this issue Oct 16, 2019
@tanhauhau @Conduitry
fix binding shadow the array in each block (#1565)
982a193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix binding shadow the array in each block tanhauhau/svelte
3 participants
@Rich-Harris @aphitiel @Conduitry