Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactive declarations with $$props don't refire if they reference other values #3286

Closed
Rich-Harris opened this issue Jul 24, 2019 · 0 comments · Fixed by #3295
Closed

Reactive declarations with $$props don't refire if they reference other values #3286

Rich-Harris opened this issue Jul 24, 2019 · 0 comments · Fixed by #3295
Labels
bug

Comments

@Rich-Harris
Copy link
Member

Describe the bug

Reactive declarations that refer to $$props should fire whenever any prop changes. Currently, this only holds true if the declaration doesn't reference anything else

To Reproduce

https://svelte.dev/repl/b51ee924d6ca407ebed0da276a8cc946?version=3.6.8

Expected behavior

Waggling either slider should cause things to be logged to the console.

Severity

It's blocking progress on Svelte GL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

always update reactive declarations with $$props sveltejs/svelte
2 participants
@Rich-Harris @Conduitry