Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<select value='{{value}}'> doesn't work as expected #423

Closed
Rich-Harris opened this issue Mar 29, 2017 · 1 comment
Closed

<select value='{{value}}'> doesn't work as expected #423

Rich-Harris opened this issue Mar 29, 2017 · 1 comment
Labels
bug

Comments

@Rich-Harris
Copy link
Member

REPL
Conduitry added a commit that referenced this issue Mar 29, 2017
@Conduitry
<select> elements should use .value prop to update value (#423)
aba21f8
@Conduitry Conduitry mentioned this issue Mar 29, 2017
Merged
Rich-Harris added a commit that referenced this issue Apr 2, 2017
@Rich-Harris
Merge pull request #427 from sveltejs/gh-423
6074178 
Make <select> elements use .value prop to update value
@Rich-Harris
Copy link
Member Author

Ack, we closed this too early. It's fixed for primitive values, but <select> (and radio/checkbox inputs) are a bit of an awkward case because their values can be non-primitives, meaning we need to use select.__value rather than select.value. REPL

@Rich-Harris Rich-Harris reopened this Apr 2, 2017
Rich-Harris added a commit that referenced this issue Apr 10, 2017
@Rich-Harris
correctly bind one-way select value attributes (#423)
93e51d6
@Rich-Harris Rich-Harris mentioned this issue Apr 10, 2017
Merged
Rich-Harris added a commit that referenced this issue Apr 10, 2017
@Rich-Harris
Merge pull request #457 from sveltejs/gh-423
e82c478 
correctly bind one-way select value attributes (#423)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Rich-Harris