Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deferred observers on components should fire after DOM updates #441

Closed
Rich-Harris opened this issue Apr 3, 2017 · 2 comments · Fixed by #448
Closed

Deferred observers on components should fire after DOM updates #441

Rich-Harris opened this issue Apr 3, 2017 · 2 comments · Fixed by #448
Labels

Comments

@Rich-Harris
Copy link
Member

REPL. Paste the following into the JSON editor:

{
  "message": "hello everybody!"
}

Expected result: the speech bubble adjusts its size immediately.

Actual result: the speech bubble doesn't change its size unless you keep typing, and it only ever updates to the previous width of the <text> element.

@Rich-Harris Rich-Harris added the bug label Apr 3, 2017
@Rich-Harris
Copy link
Member Author

@Rich-Harris
Copy link
Member Author

Ugh, pre and post were the wrong way round. Boy do I feel dumb

Rich-Harris added a commit that referenced this issue Apr 8, 2017
reverse pre and post to fix deferred observers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant