Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expect a compile error when class binding name is empty #5858

Closed
itsdonnix opened this issue Jan 5, 2021 · 1 comment · Fixed by #5939
Closed

Expect a compile error when class binding name is empty #5858

itsdonnix opened this issue Jan 5, 2021 · 1 comment · Fixed by #5939
Labels
feature request

Comments

@itsdonnix
Copy link
Contributor

itsdonnix commented Jan 5, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
Yes. Sometimes dev's maybe thought that this is a bug

Describe the solution you'd like
The compiler should give a compile error

Additional context

<h1 class:={true}>Hello!</h1>

https://svelte.dev/repl/4afa49d00f544af18d89594881340a54?version=3.31.2
@Phaqui Phaqui mentioned this issue Jan 5, 2021
Closed
Phaqui added a commit to Phaqui/svelte that referenced this issue Jan 29, 2021
@Phaqui
Fixes sveltejs#5858: Class binding name cannot be empty
7cf806b
@Phaqui Phaqui mentioned this issue Jan 29, 2021
Merged
@Conduitry
Copy link
Member

As of 3.32.1, this is prevented at parse time - https://svelte.dev/repl/4afa49d00f544af18d89594881340a54?version=3.32.1

This was referenced Mar 8, 2021
Closed
Closed
Closed
Closed
Closed
@qurafi qurafi mentioned this issue May 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #5858: Class binding name cannot be empty Phaqui/svelte
2 participants
@itsdonnix @Conduitry