Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid noscript tags where possible #637

Closed
Rich-Harris opened this issue Jun 13, 2017 · 0 comments
Closed

Avoid noscript tags where possible #637

Rich-Harris opened this issue Jun 13, 2017 · 0 comments

Comments

@Rich-Harris
Copy link
Member

In a situation like this...

<div>{{{raw}}}</div>

...we don't need to wrap the tag in <noscript> elements in order to remove the contents of the tag when raw changes. In fact, that's true whenever the next/previous element is known. This is presumably similar (but not identical, because the elements are usually needed both before and after) to the logic that determines whether we need <!-- comment --> nodes after if/each blocks.

@Rich-Harris Rich-Harris mentioned this issue Aug 28, 2017
7 tasks
Rich-Harris added a commit that referenced this issue Aug 30, 2017
Rich-Harris added a commit that referenced this issue Aug 30, 2017
Rich-Harris added a commit that referenced this issue Aug 31, 2017
[WIP] Only insert <noscript> tags when necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant