Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observe work incorrect if component has bindings from parent #804

Closed
stalkerg opened this issue Aug 31, 2017 · 1 comment · Fixed by #809
Closed

Observe work incorrect if component has bindings from parent #804

stalkerg opened this issue Aug 31, 2017 · 1 comment · Fixed by #809
Labels
bug

Comments

@stalkerg
Copy link
Contributor

stalkerg commented Aug 31, 2017 •
edited
Loading

Subj. REPL example: https://svelte.technology/repl?version=1.34.0&gist=f9ea84a2f4f0c6c1a2745244023e8ae8

just try change field.

Example with directly observed from parent:
https://svelte.technology/repl?version=1.34.0&gist=43722dc52a63412f3f89726b5aecc16a
Rich-Harris added a commit that referenced this issue Sep 1, 2017
@Rich-Harris
prevent mutation bug from incorrectly calling observer (fixes #804)
fb97256
@Rich-Harris Rich-Harris mentioned this issue Sep 1, 2017
Merged
Rich-Harris added a commit that referenced this issue Sep 1, 2017
@Rich-Harris
Merge pull request #809 from sveltejs/gh-804
7510f9c 
prevent mutation bug from incorrectly calling observer
@Rich-Harris
Copy link
Member

thanks — fixed in 1.35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

prevent mutation bug from incorrectly calling observer sveltejs/svelte
2 participants
@Rich-Harris @stalkerg