Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getClaimStatement uses class as object property name #830

Closed
jacobmischka opened this issue Sep 8, 2017 · 1 comment
Closed

getClaimStatement uses class as object property name #830

jacobmischka opened this issue Sep 8, 2017 · 1 comment

Comments

@jacobmischka
Copy link
Contributor

Another lame IE9 problem...

It appears that getClaimStatement is using class as a property name when constructing the attributes object. This causes an error in IE9.

screenshot from 2017-09-08 11-17-36

function getClaimStatement(
generator: DomGenerator,
namespace: string,
nodes: string,
node: Node
) {
const attributes = node.attributes
.filter((attr: Node) => attr.type === 'Attribute')
.map((attr: Node) => `${quoteProp(attr.name)}: true`)
.join(', ');
const name = namespace ? node.name : node.name.toUpperCase();
return `@claimElement(${nodes}, "${name}", ${attributes
? `{ ${attributes} }`
: `{}`}, ${namespace === namespaces.svg ? true : false})`;
}

jacobmischka added a commit to jacobmischka/svelte that referenced this issue Sep 8, 2017
@jacobmischka
Copy link
Contributor Author

Hm for what it's worth it seems like IE9 should allow this as is, not sure what's wrong with my IE9 vm that's making it error here.

Rich-Harris added a commit that referenced this issue Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant